[BC break] Move doctrine/cache to optional dependencies
#2912
+22
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
changed the title
doctrine/cachedoctrine/cache to optional dependencies
GromNaN
force-pushed
the
doctrine-cache
branch
from
8d2ab77 to
58b7c90
Compare
GromNaN
changed the title
doctrine/cache to optional dependenciesdoctrine/cache to optional dependencies
greg0ire
reviewed
Nov 15, 2025
Member
greg0ire
left a comment
greg0ire
left a comment
There was a problem hiding this comment.
The quick fix and the proper fix should probably be mentioned in an upgrade guide.
GromNaN
force-pushed
the
doctrine-cache
branch
from
47984e1 to
ff0af5a
Compare
GromNaN
requested review from
IonBazan,
alcaeus,
greg0ire,
jmikola,
malarzm and
paulinevos
malarzm
approved these changes
Nov 18, 2025
greg0ire
reviewed
Nov 18, 2025
greg0ire
approved these changes
Nov 18, 2025
GromNaN
force-pushed
the
doctrine-cache
branch
from
8f014e0 to
8f9a849
Compare
jmikola
reviewed
Nov 26, 2025
alcaeus
approved these changes
Nov 29, 2025
paulinevos
approved these changes
Dec 1, 2025
Move doctrine/cache to optional dependencies Add conflict with doctrine/mongodb-odm-bundle which uses doctrine/cache directly https://github.com/doctrine/DoctrineMongoDBBundle/blob/48c29009c24ff74c47782c0c9c2736f1f5fd9b0e/DependencyInjection/DoctrineMongoDBExtension.php#L14-L15 Add upgrade instructions Update UPGRADE-2.16.md Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr> Update UPGRADE-2.16.md Co-authored-by: Jeremy Mikola <jmikola@gmail.com> Update UPGRADE-2.16.md Co-authored-by: Jeremy Mikola <jmikola@gmail.com> Deprecate `Configuration::getProxyDir` and `setProxyDir` (doctrine#2911)
GromNaN
force-pushed
the
doctrine-cache
branch
from
5b8ba0f to
04cea4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
doctrine/cacheis deprecated and archived.Motivation for introducing a breaking change:
doctrine/mongodb-odmwith composer, you get a message even ifdoctrine/cacheis not actively used.This is a breaking change only when calling
Configuration::getMetadataCacheImpl(). The workaround is easy: adddoctrine/cacheas project dependency.I consider projects that use
doctrine/cachedirectly without explicitly requiring the package to be in error.That's why I'm adding a conflict with
doctrine/mongodb-odm-bundle < 5, which did not have an explicit dependency but used theDoctrine\Common\Cacheclasses:https://github.com/doctrine/DoctrineMongoDBBundle/blob/48c29009c24ff74c47782c0c9c2736f1f5fd9b0e/DependencyInjection/DoctrineMongoDBExtension.php#L14-L15